dxatscale / sfpowerscripts

A build system for modular development in Salesforce
https://dxatscale.io
MIT License
213 stars 98 forks source link

Similarly-named packages are built unnecessarily #1396

Closed thraco closed 1 year ago

thraco commented 1 year ago

Describe the bug Additional packages are built unnecessarily when code changes in a similarly-named package.

To Reproduce Steps to reproduce the behavior:

Expected behavior During the build, the change to integrations-core are found and a new integrations-core package is built.

Screenshots During the build, the change to integrations-core are found and two new packages are built: integrations-core and integrations. On comparing the previous and new packages for integrations, no differences are found.

Platform Details (please complete the following information):

Additional context Screenshots of the log files showing this issue are attached. integrations-core integrations

azlam-abdulsalam commented 1 year ago

@thraco Thanks for raising this. Will be looking at it. Interesting one :) I think i have an idea why it happens probably a bug with how the tags are parsed

azlam-abdulsalam commented 1 year ago

@thraco This is the issue area

https://github.com/dxatscale/sfpowerscripts/blob/7c5d9d4be4d2d4036175f750f3b0444db5223d14/packages/core/src/package/diff/PackageDiffImpl.ts#L74-L80