dxatscale / sfpowerscripts

A build system for modular development in Salesforce
https://dxatscale.io
MIT License
213 stars 98 forks source link

Bugfix/use lower uid in dockerfiles #1409

Closed rody closed 1 year ago

rody commented 1 year ago

Summary generated by Reviewpad on 15 Sep 23 03:39 UTC

This pull request includes three patches.

Patch 1/3 updates the base image from salesforce/cli:2.5.8-full to node:20-bookworm and removes the unused cache from npm and yarn. It also installs the necessary dependencies for the bundled version of Chromium that Puppeteer uses.

Patch 2/3 updates the debian base during installation by upgrading to the latest version and installing git, curl, and sudo.

Patch 3/3 further updates the base image from node:20-bookworm to ubuntu:22.04 and installs additional dependencies like chromium-bsu and gnupg. It also installs Node.js via nodesource and installs yarn.

Overall, these patches update the base image, add and remove dependencies, and optimize the installation process.

Checklist

All items have to be completed before a PR is merged

reviewpad[bot] commented 1 year ago

Reviewpad Report

:bangbang: Errors

:warning: Warnings

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (8de5d1c) 46.87% compared to head (0b316a5) 46.87%.

:exclamation: Current head 0b316a5 differs from pull request most recent head 0386c9f. Consider uploading reports for the commit 0386c9f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1409 +/- ## ======================================= Coverage 46.87% 46.87% ======================================= Files 70 70 Lines 2658 2658 Branches 308 308 ======================================= Hits 1246 1246 Misses 1384 1384 Partials 28 28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.