dxatscale / sfpowerscripts

A build system for modular development in Salesforce
https://dxatscale.io
MIT License
213 stars 98 forks source link

Work Item Filters Does not work with multiple filters #1415

Closed brandonmikeska closed 1 year ago

brandonmikeska commented 1 year ago

Describe the bug When attempting to use workItemFilters for change logs, if you try to use multiple filters, it puts them all as one comma separated filter.

To Reproduce Add multiple filters to your release definition.

Expected behavior When the WorkItemUpdater is attempting to match the filters, the for of should loop the filters instead of just always finding one filter.

Screenshots N/A

Platform Details (please complete the following information):

Additional context This line https://github.com/dxatscale/sfpowerscripts/blob/524c283992508adcb413e2f3303c39558400a31d/packages/sfpowerscripts-cli/src/impl/release/ReleaseImpl.ts#L82

Currently is: workitemFilters.push(releaseDefinition.changelog?.workItemFilters);

Could be changed to: workitemFilters.push(...releaseDefinition.changelog?.workItemFilters);

I don't have access to create a branch for a pull request but I think if you do this and update the WorkItemUpdater.test.ts to have two string values it should cover the code and a good test to see it not work before this change.

azlam-abdulsalam commented 1 year ago

@brandonmikeska you can create a PR from a fork, please feel to create one!

brandonmikeska commented 1 year ago

@azlam-abdulsalam done https://github.com/dxatscale/sfpowerscripts/pull/1429

azlam-abdulsalam commented 1 year ago

Thanks @brandonmikeska , its merged