Open azlam-abdulsalam opened 1 year ago
Reviewpad Report
:warning: Warnings
All modified lines are covered by tests :white_check_mark:
Comparison is base (
077009f
) 46.80% compared to head (c66998b
) 46.80%.:exclamation: Current head c66998b differs from pull request most recent head e9e918f. Consider uploading reports for the commit e9e918f to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Great enhancement. We recently talked about it with the team as we started to accumulate so many env variables that we need to maintain.
Nice!!
This a a great idea!
Add a DR proposing change to aliasfy package to eliminate redundancy
Summary generated by Reviewpad on 09 Oct 23 02:47 UTC
This pull request proposes changes to the aliafy package in order to eliminate redundancy. The current implementation of aliasified packages introduces redundancy by duplicating the contents of the 'default' directory across multiple environment-specific directories. The proposed solution is to introduce a layer of inheritance for aliasified packages, where the contents in the 'default' directory will be merged with the contents in the
<alias>
directory if an alias is matched. By implementing this inheritance mechanism, the PR aims to reduce redundancy, simplify maintenance, and minimize the scope for errors.Checklist
All items have to be completed before a PR is merged