dxatscale / sfpowerscripts

A build system for modular development in Salesforce
https://dxatscale.io
MIT License
213 stars 98 forks source link

docs(dr): propose changes to aliasfy package #1418

Open azlam-abdulsalam opened 1 year ago

azlam-abdulsalam commented 1 year ago

Add a DR proposing change to aliasfy package to eliminate redundancy

Summary generated by Reviewpad on 09 Oct 23 02:47 UTC

This pull request proposes changes to the aliafy package in order to eliminate redundancy. The current implementation of aliasified packages introduces redundancy by duplicating the contents of the 'default' directory across multiple environment-specific directories. The proposed solution is to introduce a layer of inheritance for aliasified packages, where the contents in the 'default' directory will be merged with the contents in the <alias> directory if an alias is matched. By implementing this inheritance mechanism, the PR aims to reduce redundancy, simplify maintenance, and minimize the scope for errors.

Checklist

All items have to be completed before a PR is merged

reviewpad[bot] commented 1 year ago

Reviewpad Report

:warning: Warnings

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (077009f) 46.80% compared to head (c66998b) 46.80%.

:exclamation: Current head c66998b differs from pull request most recent head e9e918f. Consider uploading reports for the commit e9e918f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1418 +/- ## ======================================= Coverage 46.80% 46.80% ======================================= Files 70 70 Lines 2662 2662 Branches 302 302 ======================================= Hits 1246 1246 Misses 1414 1414 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ruslan-kurchenko commented 1 year ago

Great enhancement. We recently talked about it with the team as we started to accumulate so many env variables that we need to maintain.

dieffrei-psignite commented 1 year ago

Nice!!

pogilvieCB commented 1 year ago

This a a great idea!