search

dxfjs / writer

A JavaScript dxf generator written in TypeScript.
https://dxf.vercel.app
MIT License
83 stars 17 forks source link

Supports extrusion property for more entity types. #66

Closed FishOrBear closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 76.47% and project coverage change: -0.01 :warning:

Comparison is base (b00fc5a) 95.75% compared to head (582c267) 95.74%.

:exclamation: Current head 582c267 differs from pull request most recent head 4e9addd. Consider uploading reports for the commit 4e9addd to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #66 +/- ## ========================================== - Coverage 95.75% 95.74% -0.01% ========================================== Files 70 70 Lines 7230 7240 +10 Branches 515 517 +2 ========================================== + Hits 6923 6932 +9 - Misses 307 308 +1 ``` | [Impacted Files](https://codecov.io/gh/dxfjs/writer/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dxfjs) | Coverage Δ | | |---|---|---| | [src/Sections/EntitiesSection/Entity.ts](https://codecov.io/gh/dxfjs/writer/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dxfjs#diff-c3JjL1NlY3Rpb25zL0VudGl0aWVzU2VjdGlvbi9FbnRpdHkudHM=) | `95.34% <75.00%> (-4.66%)` | :arrow_down: | | [src/Sections/EntitiesSection/Entities/Hatch.ts](https://codecov.io/gh/dxfjs/writer/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dxfjs#diff-c3JjL1NlY3Rpb25zL0VudGl0aWVzU2VjdGlvbi9FbnRpdGllcy9IYXRjaC50cw==) | `56.15% <100.00%> (+0.17%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dxfjs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dxfjs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tarikjabiri commented 1 year ago

Hi,

Thank you for the contribution.

What makes you say that line and point do not have extrusion property?

FishOrBear commented 1 year ago

I was wrong, they actually have this attribute.

FishOrBear commented 1 year ago

I resubmitted the code and updated the comments.

tarikjabiri commented 1 year ago

Ok I need to do some tests before merging