search

dxfrontier / cds-ts-dispatcher

SAP CAP TypeScript entity handler dispatcher.
11 stars 2 forks source link

[FEATURE] Add support for `cds v8` #85

Closed hakimio closed 3 weeks ago

hakimio commented 2 months ago

Description

cds v8 has been officially released.

Some notable changes:

Full Changelog Deprecated Features

Suggested solution

Release new major version with support for cds v8.

dragolea commented 2 months ago

hi @hakimio, Thanks, I will start working on this.

dragolea commented 1 month ago

Hi, I've opened an issue on the cds-types issue 145, as somehow the the new version 8 is acting awkard on even the most standard events like AFTER.

not sure if you tested version 8 without cds-ts-dispatcher, but looks like is breaking a lot...

P.S: I've blocked cds-ts-dispatcher & cds-ts-repository currently to version 7.

hakimio commented 1 month ago

I haven't tested it yet. Was waiting for cds-ts-dispatcher to update. Anyway, there are no "must have" features for me in v8, so I'm fine waiting until the new cds-types package issues are resolved.

Mischa1610 commented 1 month ago

Hi @dragolea I would also be happy to use cds-ts-dispatcher with CDS 8 and could support in testing if needed. (thanks for this good package) I would assume you would need to wait until your issue https://github.com/cap-js/cds-types/issues/145 is solved, did you had time to check if the PR https://github.com/cap-js/cds-types/pull/151 fixes the issues you have?

mvk-abs commented 1 month ago

Hi @Mischa1610. we didn't try the #151 yet. As @sap/cds still uses small 'each' we do not assume that with this PR all is resolved. If you like, please comment also on the issue #145 to put focus on it.

We appreciate that you like our package and salute to your colleagues :)

Mischa1610 commented 1 month ago

Hi @mvk-abs & @dragolea did you saw that there is a new cds-types release that closes the linked issue: https://github.com/cap-js/cds-types/pull/184

Would be awesome if you could keep us updated on the "support" of CDS 8 of this package.

dragolea commented 1 month ago

Hi @Mischa1610, Yep, we saw it, we will try very soon, maybe next week to make it working with CDS 8

dragolea commented 1 month ago

Hi,

Sorry, we've been catched on some internal projects and we've delayed a bit the migration to V8. I plan to work on it this week, and next week to have it migrated completly.

Thanks, Daniel

dragolea commented 3 weeks ago

Hi @Mischa1610 @hakimio, deployed dispatcher with support of CDS V8. Success

hakimio commented 3 weeks ago

Thank you, Daniel 🙂