search

dxw / accessibility-manual

How we do accessibility at dxw
https://accessibility.dxw.com
3 stars 1 forks source link

Fix netlify bot duplication #11

Closed yndajas closed 6 months ago

yndajas commented 1 year ago

The netlify bot seems to be working overtime - it's responding to each new PR twice, e.g. #8 and #9 (I deleted the first comment on #10). You can see it comments on the PR and then immediately comments again, and then the deploy preview on the first becomes invalid

I'm not sure if this is something to do with the Netlify site settings, which are linked in each of the bot's comments. I don't have permissions to view/edit them, so I can't check what options are there

yndajas commented 1 year ago

Perhaps related: https://answers.netlify.com/t/build-is-triggered-twice/1646 (and linked within: https://answers.netlify.com/t/multiple-builds-triggered-for-each-commit-or-push/900)

snim2 commented 1 year ago

There are no webhooks in the repo. Netlify is added as an app, with permissions for each repository that it needs access to.

I notice we have pending requests to add Netlify to the org, even though that has already happened. I'll reject the latest request and see what happens...

yndajas commented 1 year ago

Thanks! I don't know how this stuff works, but I'm curious to hear the results of your prodding!

snim2 commented 1 year ago

Is this still happening?

yndajas commented 6 months ago

Is this still happening?

15 months later

Yep!

yndajas commented 6 months ago

@snim2 discovered that we had the site registered in Netlify under two accounts. Deleting the site from one account (the one that wasn't doing the deploys - and also wasn't building working previews) fixed this issue