Embed labels removed - Githubissues

dy-sh / obsidian-consistent-attachments-and-links

Obsidian plugin. Move note with attachments.

MIT License

241 stars 26 forks source link

Embed labels removed #110

Closed igorakkerman closed 2 months ago

igorakkerman commented 3 months ago

With the latest update (I'm on 3.13.3), the "labels" of embeds are removed:

![Target](Target.md)

becomes

![](Target.md)

It's not an issue immediately but when I remove the ! to turn the embed into a link, the link has no label. I noticed that the label is brought back when the note is reloaded but I'd prefer it not to be removed in the first place.

mnaoumov commented 2 months ago

Fixed in https://github.com/dy-sh/obsidian-consistent-attachments-and-links/releases/tag/3.14.0

igorakkerman commented 2 months ago

@mnaoumov Thank you so much for working on the issue. Unfortunately, the problem with embeds remains in 3.14.0. Looking at your latest commits, I can't see any code changes, apart from linting and library updates.

mnaoumov commented 2 months ago

@igorakkerman yes, updating library supposed to help.

As you claim it isn't, I need more details. Please prepare a test vault and record a video proving the issue is still there.

igorakkerman commented 2 months ago

@mnaoumov before and after re-installing the plugin and running a full update, I made a backup. Below's an example diff. Please let me know if that helps or I should create another vault.

mnaoumov commented 2 months ago

@igorakkerman I need to understand what operation did you trigger that removed the labels

igorakkerman commented 2 months ago

@mnaoumov Reorganize Vault, I use a shortcut for it. Below are my settings.

mnaoumov commented 2 months ago

Fixed in https://github.com/dy-sh/obsidian-consistent-attachments-and-links/releases/tag/3.19.0

igorakkerman commented 2 months ago

Thanks so much, @mnaoumov! Seems to work perfectly now.