fix to email address and URL

dylan-profiler / visions

Type System for Data Analysis in Python

https://dylan-profiler.github.io/visions/visions/getting_started/usage/types.html

Other

203 stars 19 forks source link

fix to email address and URL #187

Closed ieaves closed 2 years ago

ieaves commented 2 years ago

The CompleteSet of types was never tested for the standard python implementation and there appear to be a few regressions. This PR includes fixes for two:

EmailAddress had two relationships registered rather than a relationship and and a transformer
URL contains_op had a typo
URL relationship wasn't correctly checking for scheme and netloc.

I don't have time right now to standup a full test suite for the CompleteSet @sbrugman, do you feel okay getting this in as a quick fix?

ieaves commented 2 years ago

It doesn't look like the standard python implementations have missing value handling / empty sequence checking either. We might want to throw a note on the README explaining which implementations are feature complete and which might have bugs.