Closed mtsitrin closed 1 week ago
Just curious why removing ctx.Err()?
- it's clearer in regard of the errgroup. we'll have a single root error, otherwise each loop will add it's error
- it's makes more sense. if your context got canceled it's graceful shutdown. shouldn't return error unless u have one
I just did a quick scan tbh
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #XXX
<-- Briefly describe the content of this pull request -->
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: