dymensionxyz / dymint

Sequencing Engine for Dymension RollApps
Other
98 stars 70 forks source link

fix(rotation): fixed race condition for last block #1244

Closed mtsitrin closed 1 week ago

mtsitrin commented 1 week ago

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:


For Reviewer:


After reviewer approval:

mtsitrin commented 1 week ago

Just curious why removing ctx.Err()?

  • it's clearer in regard of the errgroup. we'll have a single root error, otherwise each loop will add it's error
  • it's makes more sense. if your context got canceled it's graceful shutdown. shouldn't return error unless u have one
danwt commented 1 week ago

I just did a quick scan tbh