search

dymmond / lilya

Yet another ASGI toolkit that delivers
https://lilya.dev
BSD 3-Clause "New" or "Revised" License
41 stars 4 forks source link

TestClientTransport inherits from wrong base #90

Open devkral opened 1 month ago

devkral commented 1 month ago

TestClientTransport is supposed to handle ASGI but inherits from httpx.BaseTransport which is for WSGI and handles with deprecation warnings ASGI.

It should inherit of httpx.AsyncBaseTransport and implement it.

tarsil commented 1 month ago

Yes that is correct. For the async client we adopt something else. In fact you are correct. We should implement the AsyncTestClient directly.

We should also deprecate python 3.8 now