dynamicslab / pysindy

A package for the sparse identification of nonlinear dynamical systems from data
https://pysindy.readthedocs.io/en/latest/
Other
1.46k stars 324 forks source link

Trapping, extended to (a) enstrophy, and (b) local trapping #536

Closed Jacob-Stevens-Haas closed 3 months ago

Jacob-Stevens-Haas commented 4 months ago

Here are the changes that Aland and Mai (and to a lesser extent, I) have been working on to expand trapping SINDy to local stability and, in parallel, to trapping enstrophy rather than just energy.

There are a few things to iron out, but I wanted to activate CI tests and merge conflict detection at this point

Remaining:

Long term (after this PR, maybe not all)

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.31%. Comparing base (f2cdf2b) to head (94febf9). Report is 16 commits behind head on master.

Files Patch % Lines
pysindy/optimizers/constrained_sr3.py 0.00% 1 Missing :warning:
pysindy/optimizers/trapping_sr3.py 95.23% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #536 +/- ## ========================================== + Coverage 94.05% 94.31% +0.26% ========================================== Files 38 37 -1 Lines 4157 4101 -56 ========================================== - Hits 3910 3868 -42 + Misses 247 233 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jacob-Stevens-Haas commented 3 months ago

I'm going to go ahead and merge this since others are starting to PR changes to master. Fixing the last bit can be done against the master branch, and we don't need to keep extra branches around.