Closed Jacob-Stevens-Haas closed 3 months ago
Attention: Patch coverage is 90.90909%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 94.31%. Comparing base (
f2cdf2b
) to head (94febf9
). Report is 16 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pysindy/optimizers/constrained_sr3.py | 0.00% | 1 Missing :warning: |
pysindy/optimizers/trapping_sr3.py | 95.23% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm going to go ahead and merge this since others are starting to PR changes to master. Fixing the last bit can be done against the master branch, and we don't need to keep extra branches around.
Here are the changes that Aland and Mai (and to a lesser extent, I) have been working on to expand trapping SINDy to local stability and, in parallel, to trapping enstrophy rather than just energy.
There are a few things to iron out, but I wanted to activate CI tests and merge conflict detection at this point
Remaining:
_update_coef_constraints
to be generic equality-constrained least squares::math ..
and:math:
)Long term (after this PR, maybe not all)
MIOSR
constraints tofit
PolynomialLibrary
as an argument; infer data-dependent params infit()
.