Closed Jacob-Stevens-Haas closed 1 month ago
Attention: Patch coverage is 92.66055%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 95.26%. Comparing base (
ddf8d6d
) to head (22329dd
). Report is 12 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
pysindy/pysindy.py | 91.37% | 5 Missing :warning: |
pysindy/feature_library/base.py | 66.66% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey Alan, I put you as a reviewer in case you want an eye into this process. This is the beginning of what we talked about in the last meeting.
@ahsu98, @malachitewind, I'm going to add you as collaborators so you can review these changes too.
I'm going to merge it, and turn the last commit into an issue
Begin #351
This pull request begins the abstraction of the
SINDy
class, which handles a lot of methods with special cases, to a variety of classes that reflect fundamental differences between problem formulations. Here, I pull out_BaseSINDy
, which contains basic information about the feature library, system dimension, and printing the equations.Future PRs will make Weak and discrete their own classes, modify feature libraries to be amenable to jax, numpy, and cvxpy arrays, and introduce the Single-Step SINDy class and associated optimizer/problem setup.