dynamicweb / swiffy-slider

Super fast carousel and slider with touch for optimized websites running in modern browsers.
MIT License
250 stars 29 forks source link

Bare bones version? #39

Closed perdittmann closed 1 year ago

perdittmann commented 2 years ago

Is there the possibility to make a "bare bones" version of Swiffy Slider? Or does that not fit into the concept?

I have replaced a couple of old sliders on clients' websites with Swiffy Slider, and for the new slider to fit into the whole design, I had to override quite a bit of the CSS.

I do love the possibility to style the slider just by adding classes, and I am not overly bothered by loading CSS I don't end up using. But it would be great to have a .pure class (or something) that does not style the elements, so I only have to add, not to override.

As I have said before – your slider is a dream come true when I had already given up on looking for something usable and also on trying to write my own. Many, many thanks for this great piece of software – and no less for the stellar support!

nicped commented 2 years ago

Thanks - and you are welcome. Same reason we wrote this slider!!

Yeah, I do not think that would be a big issue to do something. Just need to understand which parts that would be - as I see it, the CSS only styles navigation arrows and indicators. Are you talking about the navigation and indicator styling? Or also their relative position on top of the slides?

perdittmann commented 2 years ago

Yes, it's the indicators and the arrows. For one project, I needed to move the indicators to the right side. .slider-indicators says {justify-content: center;} It was not too hard to change that – but as I said, not having the styles that are already there interfere with my CSS would be a plus. 😁

nicped commented 2 years ago

Will look into at some point - should be fairly simple!

perdittmann commented 2 years ago

That's great, thank you! Looking forward to it.

perdittmann commented 2 years ago

Any news this side of things? The next project is coming up where I could really use this. I know this is not a major issue, but it would be helpful for my workflow. So if the bare bones version should be just around the corner, I'd postpone the project a bit.

nicped commented 2 years ago

I am off on vacation very soon and have unfortunately limited time to look into this in the near future… feel free to make a pull - I should be able to look at that when in a boring meeting 😉

perdittmann commented 2 years ago

I am happy to hear that! One so busy working on this wonderful piece of software should get all the rest they need. Okay, I will look into it myself and have a go.

tleperou commented 1 year ago

🙌

In order to avoid overriding styles, as a first step, I wrapped css rules within :where (I'm not granted to push those changes @nicped)

If it doesn't opt-out from applying the style, it avoid integrations from using !important.

An option could be creating several css files

nicped commented 1 year ago

I do like the idea of this - but have not come around to it. There is a relatively large amount of opinionated default styles that could be left out with this - which I like a lot to keep things nice and tidy.

tleperou commented 1 year ago

I can push the branch 39-lower-css-specificity from my local to the remote. And let you give a look if your have time.

The next step could be test against the examples of the doc before reviewing the changes I presume.

Special thanks for your effort, I love the way you tackle the matter 👌


remote: Permission to dynamicweb/swiffy-slider.git denied to tleperou.
fatal: unable to access 'https://github.com/dynamicweb/swiffy-slider.git/': The requested URL returned error: 403

🙏

nicped commented 1 year ago

I do not know where that branch is - maybe in your own fork? I cannot see it in this repo. On this page on the right panel, you have a section called "Development" where you can create a branch for this subject. So do that, check it out and move your changes to that branch.

tobiasbaehr commented 1 year ago

@tleperou You need to fork, then you can create a PR.

You can not push in another repository without you got access for this repository. :D