search

e-alfred / nextcloud-scanner

Scanner app for Nextcloud using the SANE framework
GNU Affero General Public License v3.0
23 stars 10 forks source link

Compatible with nextcloud 28 #39

Open Boc-chi-no opened 1 year ago

Boc-chi-no commented 1 year ago

38 #26 Compatible with nextcloud 28

[U] Refactored project structure to adhere to PSR-4 standards [U] Eliminated sudo usage for enhanced security

farrad commented 4 months ago

@Boc-chi-no Thanks for your efforts to fix the compatibility issue!

I tested your fix and for me still the following Fatal error occurs:

    "File": "/var/www/html/custom_apps/scanner/lib/AppInfo/Application.php",
    "Line": 43,
    "message": "Error during app service registration: Call to undefined method OC\\Server::getEventDispatcher()",
    "exception": [],
    "CustomMessage": "Error during app service registration: Call to undefined method OC\\Server::getEventDispatcher()"

Do you think you could also adjust to the breaking change of the Event API in the NC28 ?

Boc-chi-no commented 4 months ago

@Boc-chi-no Thanks for your efforts to fix the compatibility issue!

I tested your fix and for me still the following Fatal error occurs:

    "File": "/var/www/html/custom_apps/scanner/lib/AppInfo/Application.php",
    "Line": 43,
    "message": "Error during app service registration: Call to undefined method OC\\Server::getEventDispatcher()",
    "exception": [],
    "CustomMessage": "Error during app service registration: Call to undefined method OC\\Server::getEventDispatcher()"

Do you think you could also adjust to the breaking change of the Event API in the NC28 ?

Oh, I see the issue now. I might have mistakenly thought it was compatible with NC28 when it was actually for NC27. I'll update my server, then I'll look into this issue and make it compatible with NC28.

farrad commented 2 months ago

See compatible version for Nextcloud 28 and 29 in this pull request.

Note it is NOT backward compatible.