search

e-gineering / gitflow-helper-maven-plugin

An extension and plugin that teaches Maven to work well with gitflow projects and CI servers.
Apache License 2.0
76 stars 21 forks source link

Added m2e lifecycle mappings #76

Closed MouettE-SC closed 6 years ago

MouettE-SC commented 7 years ago

In order to use a project in eclipse with this plugin, needed to add a lifecycle mapping file so m2e ignores the plugin's goals (not to be used in the IDE).

bvarner commented 7 years ago

It seems like set-properties and enforce-versions might be something you'd want the IDE to do as part of it's build cycle.

I'm not much of an eclipse user, so I'm not sure what the risk there would be. Care to weigh in?

MouettE-SC commented 7 years ago

It seems like set-properties and enforce-versions might be something you'd want the IDE to do as part of it's build cycle.

You are right, it would definitely be a useful addition in the IDE. I just started to use your plugin so it's going to take me little more time to fully understand it and correctly apply it to my projects (so far it's pretty amazing :-) ). I will try to change the mapping configuration and see if it works in eclipse; afterwards I'll update the PR.

bvarner commented 7 years ago

Great! Thanks for the submission -- I look forward to the updated PR!

(Once this change is in, I'll probably do a hotfix release with this addition -- since Eclipse is kind of a big thing.)

bvarner commented 7 years ago

Any update on this?

MouettE-SC commented 7 years ago

I'm sorry I'm on vacation until the 27th. The attempts I tried before leaving were not very successful though. Documentation is very sparse on the maven integration so it's probably going to take some time to get things working.