search

e-kotov / rJavaEnv

Java Environments for R Projects
http://www.ekotov.pro/rJavaEnv/
Other
12 stars 1 forks source link

check md5 #19

Closed pachadotdev closed 4 months ago

pachadotdev commented 4 months ago

hi!

this saved me a few struggles with a specific Java version

the file was not installing correctly, so I added a check to verify the md5, which in my case was because of an incomplete download

e-kotov commented 4 months ago

@pachadotdev thank you so much for taking the time to test the package and even suggest these improvements! md5 check will definitely improve the stability for people with unreliable connections. I'm not sure your current code will work with all Java distors, but for now it works very well with Corretto. I will keep the checksum checks in mind when I start adding new Java distros.

I added you to the list of contributors: https://github.com/e-kotov/rJavaEnv/blob/0260dc914bf93a246005f987140711adfa439e99/DESCRIPTION#L7-L8