e107inc / e107

e107 Bootstrap CMS (Content Management System) v2 with PHP, MySQL, HTML5, jQuery and Twitter Bootstrap. Issue Discussion Room: https://gitter.im/e107inc/e107
https://e107.org
GNU General Public License v3.0
321 stars 213 forks source link

USER_AREA is defined true in menu manager - conflicts with e_header #4555

Open Jimmi08 opened 3 years ago

Jimmi08 commented 3 years ago

Bug Description

this is recommended solution for not inserting e_header css in admin area

if(deftrue('USER_AREA')) // prevents inclusion of JS/CSS/meta in the admin area.

but USER_AREA is defined true in preview (menu manager)

In my case, the plugin uses class "column" and the result in the preview is (width is 50 %) : image

This was solution: if(deftrue('USER_AREA') && (e_PAGE != "menus.php") ) but I think it is correct. If it is, it should be added to e_header.php of _blank plugin

Otherwise:

It is not so the big difference with bootstrap3 theme, but with theme, without bootstrap markup, it can look like this: image

THanks

Jimmi08 commented 3 years ago

@Deltik According to your last fix, in e_header should be e_MENUMANAGER_ACTIVE != true used too? {instead of (e_PAGE != "menus.php")) Big thanks

Deltik commented 3 years ago

I don't quite understand this issue. Are you talking about e107_plugins/_blank/e_header.php?

If e_MENUMANAGER_ACTIVE === true, then USER_AREA === true, too.

Jimmi08 commented 3 years ago

Yes, there is an example of how to use e_header correctly only on the front site, not in backend. But it fails in the Menu manager (exactly theme preview and frontend css influences menu manager look - menus areas in my case).

Ignore this, I thought that it could fix this too. Probably not. I can live with e_PAGE. Thanks.