search

e2nIEE / pandapower

Convenient Power System Modelling and Analysis based on PYPOWER and pandas
https://www.pandapower.org
Other
888 stars 484 forks source link

Outdated docstrings in create_sgen and create_gen functions #372

Closed gdgarcia closed 5 years ago

gdgarcia commented 5 years ago

Some parts of the docstrings of create/create_sgen and create/create_gen functions still refer to sgen and gen as created using the consumer system. But according to the new documentation, they are in fact created using the generator convention since pandapower 2.0.0, as told in Unit System and Conventions Is this issue correct? Am I missing something? If it's correct, I'd like to update the docstrings accordingly. Thanks.

ascheidl commented 5 years ago

hello,

you are correct. Seems like the docstrings are partially not updated yet.

If you want to help to correct the docstrings please make a pull request.

cheers, alex