eBay / ebayui-core

Collection of Marko widgets; considered to be the core building blocks for all eBay components, pages & apps
https://ebay.github.io/ebayui-core/
Other
224 stars 104 forks source link

ebay-carousel: controls fail to render in a closed dialog #2302

Closed sendlo closed 1 month ago

sendlo commented 1 month ago

Bug Report

eBayUI Version: ^14

Description

I want to render a carousel within a dialog. But if the dialog is closed when the carousel renders, the controls don't become active when the dialog is opened. A long while back I remember this same thing happening if the container resized.

Ideally we could have an event we can trigger that tells the dialog to try to reapply the carousel controls. That way I could trigger this once I know the dialog is open.

Workaround

I am delaying rendering the carousel until after the dialog is open. But that means there is flash before the render.

agliga commented 1 month ago

You can force the carousel to rerender by changing the state to dirty on carousel open. There really isn't a fix for this since you can force the rerender in your app.