search

eHarmony / aloha

A scala-based feature generation and modeling framework
http://eharmony.github.io/aloha
MIT License
60 stars 12 forks source link

Closes #185 #188

Closed deaktator closed 7 years ago

deaktator commented 7 years ago

Summary

Provides an auditor that returns an Either. The Either has failure information or a success value.

There is some commented code in the check-in. That is there on purpose because I wanted to get opinions about wether to include the code that was commented out or whether it should be deleted.

Resolves

Bug Fixes/New Features

Side Effects

None (ha ha)

How to Verify

Check tests

Tests

EitherAuditorTest should be comprehensive.

Code Reviewer(s)

@jmorra

deaktator commented 7 years ago

BTW. I'm leaning towards deleting the commented out code rather than including the code that is commented out.

deaktator commented 7 years ago

Merged to development branch.