search

eProsima / Fast-CDR

eProsima FastCDR library provides two serialization mechanisms. One is the standard CDR serialization mechanism, while the other is a faster implementation of it. Looking for commercial support? Contact info@eprosima.com
Apache License 2.0
142 stars 100 forks source link

[20327] Do not build test if CMake < 3.22 #204

Closed EduPonz closed 6 months ago

EduPonz commented 6 months ago

This PR avoids building the tests if CMake < 3.22 even when specified via CMake option.

EduPonz commented 6 months ago

Github CI running here

clalancette commented 6 months ago

Here's a CI run on RHEL on ROS 2 infrastructure with this in place:

clalancette commented 6 months ago

Here's a CI run on RHEL on ROS 2 infrastructure with this in place:

That looks good to me; the one flaky test there is unrelated with this PR.

MiguelCompany commented 6 months ago

With the Github CI, I don't think we need to wait for the Jenkins queue for Mac. Going in.

richiprosima commented 6 months ago

Build status: