Implementation of XCDR introduces new functions in TopicDataType class. But the old one remained. This PR removes them before launching the major version 3, and also performs additional refactorings:
Change method names to snake_case and have more meaningful names.
Change arguments from pointer to reference where applicable
Use std::string instead of char* on name getters and setters
Contributor Checklist
[x] Commit messages follow the project guidelines.
[x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A New feature has been documented/Current behavior is correctly described in the documentation.
N/A Applicable backports have been included in the description.
Reviewer Checklist
[x] The PR has a milestone assigned.
[x] The title and description correctly express the PR's purpose.
[x] Check contributor checklist is correct.
[x] Check CI results: changes do not issue any warning.
[x] Check CI results: failing tests are unrelated with the changes.
Description
Implementation of XCDR introduces new functions in
TopicDataTypeclass. But the old one remained. This PR removes them before launching the major version 3, and also performs additional refactorings:snake_caseand have more meaningful names.std::stringinstead ofchar*on name getters and settersContributor Checklist
Reviewer Checklist