eXtensibleCatalog / test

Testing
MIT License
0 stars 0 forks source link

Drupal not consistent with NCIP reponse display #127

Closed patrickzurek closed 7 years ago

patrickzurek commented 7 years ago

JIRA issue created by: rcook Originally opened: 2011-10-28 06:43 PM

Issue body: (nt)

This issue has attachments associated with it (external link): 952-one-holding.png civil.png microform.png ncip1.png ncip2.png

patrickzurek commented 7 years ago

JIRA Comment by user: rcook JIRA Timestamp: 2011-10-28 06:49 PM

Comment body:

Consider the first two results below. You show different availability messages for these two results, but using the NCIP test page in Drupal, I get the same response (see attached). Neither of these two records have items in Voyager, and so should eventually behave the way outlined in DRUPAL-377 but most troubling is that they behave differently now. They should display the same.

Notifying Jennifer and Dave to give input on demo required or not decision.

patrickzurek commented 7 years ago

JIRA Comment by user: dlindahl JIRA Timestamp: 2011-10-29 07:24 PM

Comment body:

Randy, I am forced to guess at what you are trying to say. Just tell me what you think the screen should say. I don't understand.

Are you saying that we have no items for these things, and it should say "Availability unknown" or "Not available" or "Not circulating" or what. If you don't know what it should say, you still need to decide what it should say and explain why your suggestion is not quite right, so I can try to improve on the idea if I can.

After that, I will suggest whether or not this needs to go into the demo.

patrickzurek commented 7 years ago

JIRA Comment by user: dlindahl JIRA Timestamp: 2011-10-29 07:31 PM

Comment body:

Ooop, sorry Randy (read my last response) I see that you suggest something in the referenced ticked 951. So, I guess I still don't understand though.

Here is my thought. We need to explain to the user what is going on. "Availability unknown" is a terrible thing to put on the screen it is not helpful. If it is microform, and that is the reason that there is no item record, then "availability unknown" is not really telling the user what is going on. Let's try to be verbose about what we are telling the user in our first proposals for solving this problem and then refine that. And let's do this BEFORE we assign this to peter.

So, what are the cases, and the status's for each? Can we look at item type and NCIP response in combination to determine what status message to display in each case? I think we need to list out the cases. I am assigning to Jennifer, but Randy and Peter, you can comment too.

patrickzurek commented 7 years ago

JIRA Comment by user: rcook JIRA Timestamp: 2011-10-31 05:38 PM

Comment body:

What we display is something that belongs in issue 951, and that might take a while to figure out.

This issue is about Drupal displaying completely different status "Not Available" and "Multiple Items Available" for 2 different results when the NCIP response for each of those results is the same. Drupal Toolkit is doing something wrong. I would expect them to both say "Not Available" given the current coding.

patrickzurek commented 7 years ago

JIRA Comment by user: pkiraly JIRA Timestamp: 2011-11-04 05:47 PM

Comment body:

Randall, it is not a bug, it is a feature ;-) There is a rule, that if the item in question is a journal, and it is available (independently if only one call number or multiple call number came back from NCIP/Holdings record), we display "Multiple items available." The item in your example is a journal so this rule activated. We can decide whether we should change this rule if the call number came from Holdings record, and not from NCIP, but I did not change the current behaviour. Please let me know if I have to change it.

patrickzurek commented 7 years ago

JIRA Comment by user: rcook JIRA Timestamp: 2011-11-15 04:01 PM

Comment body:

Get's resolved with DRUPAL-377

patrickzurek commented 7 years ago

JIRA Comment by user: rcook JIRA Timestamp: 2011-12-01 02:51 PM

Comment body:

Peter, this first case continues to say "loading"....if you get nothing back you are supposed to use the holding record data.

patrickzurek commented 7 years ago

JIRA Comment by user: pkiraly JIRA Timestamp: 2011-12-01 04:03 PM

Comment body:


Now I fixed this case (there is one item, and that comes from holdings instead of NCIP).

patrickzurek commented 7 years ago

Issue resolved: 2011-12-01 04:03 PM