search

eamigo86 / graphene-django-extras

Extras functionalities for Graphene-Django
MIT License
417 stars 108 forks source link

Fixed @date directive loosing a time information #137

Closed Zagrebelin closed 4 years ago

Zagrebelin commented 4 years ago

datetime.datetime is subclass of datetime.date, so isinstance(datetime_instance, datetime.date) check is True and we loosing a time information here.

codecov[bot] commented 4 years ago

Codecov Report

Merging #137 into master will increase coverage by 3.46%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   50.17%   53.63%   +3.46%     
==========================================
  Files          24       24              
  Lines        1965     1965              
==========================================
+ Hits          986     1054      +68     
+ Misses        979      911      -68
Impacted Files Coverage Δ
graphene_django_extras/directives/date.py 48.29% <50.00%> (+32.65%) :arrow_up:
graphene_django_extras/registry.py 90.32% <0.00%> (+3.22%) :arrow_up:
graphene_django_extras/base_types.py 70.68% <0.00%> (+6.03%) :arrow_up:
graphene_django_extras/middleware.py 100.00% <0.00%> (+66.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ddc2ed9...d875299. Read the comment docs.