search

eamigo86 / graphene-django-extras

Extras functionalities for Graphene-Django
MIT License
417 stars 108 forks source link

Fixed update mutation on DjangoSerializerMutation. #156

Closed bloodwithmilk25 closed 1 year ago

bloodwithmilk25 commented 4 years ago

There was no distinction between create and update operations, thus update did not have an ID argument in it. I made it so update takes ID argument not from input but from a level higher, just like the delete does. Also, now that both update and delete take it, I could remove the else block.

codecov[bot] commented 4 years ago

Codecov Report

Merging #156 into master will decrease coverage by 0.02%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   53.65%   53.63%   -0.03%     
==========================================
  Files          24       24              
  Lines        1968     1969       +1     
==========================================
  Hits         1056     1056              
- Misses        912      913       +1
Impacted Files Coverage Δ
graphene_django_extras/mutation.py 32.27% <0.00%> (-0.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update abb5a33...009b398. Read the comment docs.