earthiverse / picknic

Picknic || A Picnic recommendation engine.
https://picknic.site
MIT License
5 stars 4 forks source link

Fix const issues in data grabbers #15

Open earthiverse opened 5 years ago

earthiverse commented 5 years ago

In /source/data/ we have many files that grab picnic table data. In some of these files, we use const variables instead of let variables. That doesn't really make sense for every variable. Some of them should be let. If you understand the difference between const and let, unlike us, please help us fix our scripts!

Example of a script with const issues: https://github.com/earthiverse/picknic/blob/master/source/data/CA/AB/Airdrie_PicnicTables.ts

Grommers00 commented 5 years ago

Hey I'd like to work on this if thats okay?

Grommers00 commented 5 years ago

I've sent over Canada, let me know if this is what you are looking for. Technically your const should work in those scenarios. However, Let would allow for manipulation of the data fields later. Let me know!