search

earthlab / autograding-notebooks

sample notebooks and notes for autograding project
MIT License
1 stars 1 forks source link

Feedback report does not correctly sum total points #7

Closed lwasser closed 5 years ago

lwasser commented 5 years ago

@jlpalomino noted this notebook as an example of this issue:

https://github.com/earth-analytics-edu/assignment1-lherwehe/

Jenny can you add more specifics here to this issue. @kcranston do you need anything else to work on it?

jlpalomino commented 5 years ago

There appears to be an error in how the total number of points for the notebook is generated from the credit that is assigned to each cell. In Lauren's example notebook, we purposefully added a mistake, so that the last cell achieved only 13 out of 15 points.

However, the feedback report assigned a score of 15 out of 15 points for that cell, instead of the 13 points that were earned in that cell.

kcranston commented 5 years ago

This was not an nbgrader partial credit bug - it was an problem with the github scripts and some leftover files from previous testing. See feedback report from Laruen's notebook, which now reports the correct score. Yay!