search

earthrise-media / vacs-map

Exploring VACS project data
1 stars 0 forks source link

Add updated crop property data #46

Closed kelsey-taylor closed 10 months ago

kelsey-taylor commented 10 months ago

blocked by not having the data from AgMIP

kelsey-taylor commented 10 months ago

from https://github.com/earthrise-media/vacs-map/pull/56#pullrequestreview-1748187669:

these look great! the only issues i see appear data-related:

  1. no values for storage potential in the data and therefore the sort for that property doesn't work
  2. missing some descriptions (ex. African eggplant and fonio), so those don't show up in the crop profile page

assuming those will be fixed as part of https://github.com/earthrise-media/vacs-map/issues/46, going to go ahead and merge this. will add a note to that PR with this info so we can make sure to double check once the data has been updated