Fixes #14: false positive errors in validation

ebi-ait / ingest-graph-validator

HCA Ingest Service Graph Validation Suite

MIT License

1 stars 0 forks source link

Fixes #14: false positive errors in validation #15

Closed rays22 closed 4 years ago

rays22 commented 4 years ago

Fixes #14

Test plan

The following test file should pass validation by ensure_seq_libr_prep_protocols.adoc 2protocols-test_pass.xlsx
The following test files should fail validation by ensure_seq_libr_prep_protocols.adoc 2protocols-test_fail-1.xlsx 2protocols-test_fail-2.xlsx 2protocols-test_fail-3.xlsx

Test files are attached to #14 .

ESapenaVentura commented 4 years ago

LGTM 👍

I have tested a couple of spreadsheets and looks ok. With a quick search, I have not been able to look at what the operator "<>" does. Could you point me to docs or briefly explain its function?

rays22 commented 4 years ago

I have tested a couple of spreadsheets and looks ok. With a quick search, I have not been able to look at what the operator "<>" does. Could you point me to docs or briefly explain its function?

Thanks @ESapenaVentura for testing the fix so quickly.

<> is an operator to test inequality. In this test I am using OPTIONAL MATCH so that I can return the sequence file names that lack one or two of the required protocols. I thought it would make it easier for the users to fix the errors that way. Without returning the file names, the test could have been made simpler.