search

ebi-ait / ingest-graph-validator

HCA Ingest Service Graph Validation Suite
MIT License
1 stars 0 forks source link

Review all tests to detect outdated/failing tests #29

Closed ESapenaVentura closed 3 years ago

ESapenaVentura commented 3 years ago

Related to #27 but also need to check everything

rays22 commented 3 years ago

False graph validation errors

graph_tests.log

Marion and I have found these four false validation errors while running the graph test set (as of 2021-05-14) on the metadata of GSE156707 - HumanHeartMaturationsnSeq #298.

  1. contains_cell_barcode_info.adoc
    • I think this test should be conditional depending on the library_preparation_protocol.nucleic_acid_source value.

Test description When a sequencing protocol is non-10x, non-ss2, test whether metadata is complete.

  1. contains_umi_barcode_info.adoc
    • I think this test should be conditional depending on the library_preparation_protocol.nucleic_acid_source value.

Test description When a sequencing protocol is non-10x, non-ss2, test whether metadata is complete.

  1. 10x_has_more_than_2_files.adoc
    • I think this test should take into account and check the sequence_file.lane_index field before raising an error.

Test description Processes using 10x library preparation protocols have 2 to 4 files linked.

  1. paired_end_2_files.adoc This test has raised false errors when testing dataset https://github.com/ebi-ait/hca-ebi-wrangler-central/issues/298 .

Test description When a sequencing protocol is paired-end, test whether it has 2 or more files linked.