Fixed sequence_file to cell_suspensions test

ebi-ait / ingest-graph-validator

HCA Ingest Service Graph Validation Suite

MIT License

1 stars 0 forks source link

Fixed sequence_file to cell_suspensions test #34

Closed ESapenaVentura closed 3 years ago

ESapenaVentura commented 3 years ago

Related to #8

Now only checks for not-cell suspension --> sequence file when:

Nucleic acid source is "single cell"
File is a sequence file

ESapenaVentura commented 3 years ago

To test I used a normal spreadsheet and a modified version of one of the example spreadsheets: TEST_10x_generic.xlsx

mshadbolt commented 3 years ago

Will this test fail if we start having cell_suspension --> analysis_file for projects where we can't publish raw data?

ESapenaVentura commented 3 years ago

It shouldn't because the path is targeting is the ones that include sequence files!

mshadbolt commented 3 years ago

ok cool, I think this will fix the error I identified but I think maybe sometime we have single cell projects that go direct from specimen to cell suspension when the specimen is blood?

ESapenaVentura commented 3 years ago

I thought we were modelling it as specimen --> cell suspension even if there was no dissociation/enrichment? at least that's how I've been modelling it every time

mshadbolt commented 3 years ago

Yeah I do the same as you, but I think there are some projects that have that specimen-> cell suspension linking

ESapenaVentura commented 3 years ago

I just noticed I should also include "single nuclei" in the test