ebi-gene-expression-group / atlas-web-bulk

Bulk Expression Atlas web application
Apache License 2.0
0 stars 1 forks source link

Fix initialisation order in DifferentialExperimentContrastLines's constructor #219

Closed ke4 closed 5 days ago

ke4 commented 5 days ago

Experiment design variable was initialised after it was used in buildContrastDetails method in the constructor. For this reason we got a NPE exception when we tried to use it in the buildContrastDetails method. I had to swap the initialisation order in DifferentialExperimentContrastLines's constructor.

Unfortunately nobody wrote tests for this class. :-( We need to merge and deploy this change ASAP. I am going to add a ticket for writing tests and that is going to be done later, hopefully during next sprint. Not very ideal. :-(