Refactor ExpressionAtlasContentService class - Githubissues

ebi-gene-expression-group / atlas-web-single-cell

Single Cell Expression Atlas web application

Apache License 2.0

5 stars 5 forks source link

Refactor ExpressionAtlasContentService class #484

Open ke4 opened 2 weeks ago

ke4 commented 2 weeks ago

ExpressionAtlasContentService class is very badly written. 😞

There are no unit tests.
Its constructor taking 21!!!! parameters.
externalResourceLinks method should be cleaned Probably there are other parts of this class that need to be cleaner.

Steps:

[ ] Add unit tests
[ ] Refactor the constructor
[ ] Clean the externalResourceLinks method
[ ] In general clean the code