search

ebkalderon / renderdoc-rs

RenderDoc application bindings for Rust
Apache License 2.0
45 stars 6 forks source link

Bump minimum Rust version to 1.33 #50

Closed ebkalderon closed 5 years ago

ebkalderon commented 5 years ago

It seems that percent-encoding 2.1.0 is using let bindings in const fn which is causing this CI build to fail on stable Rust 1.31 with the following error:

error: local variables in const fn are unstable
  --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/percent-encoding-2.1.0/lib.rs:72:13
   |
72 |         let chunk = self.mask[byte as usize / BITS_PER_CHUNK];
   |             ^^^^^

This feature was only stabilized in Rust 1.33 according to this comment. As such, we should probably bump ebkalderon/renderdoc-rs-circleci-dockerfile to a minimum Rust compiler version 1.33.

ebkalderon commented 5 years ago

I have opened a counterpart issue on the CI Dockerfile repo here: https://github.com/ebkalderon/renderdoc-rs-circleci-dockerfile/issues/1.