ebonhold / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
0 stars 0 forks source link

Implement Seismic Reverberation #963

Closed Armadk closed 1 month ago

Armadk commented 2 months ago

This still needs to be done. Cleave can be turned into a base, as can thunderclap. This can get done along with Mountain Thane.

95738
Changed Seismic Reverberation (id=382956)
--- 
+++ 
@@ -1,29 +1,29 @@
 Name             : Seismic Reverberation (id=382956) [Spell Family (4), Passive] 
 Talent Entry     : Generic [tree=class, row=7, col=4, max_rank=1, req_points=8, select_idx=0]
 Class            : Warrior
 School           : Physical
 Spell Type       : None
 Attributes       : ......x. ........ ........ ........   ........ ........ ........ ........ 
                  : ........ x....... ........ ........   ........ ........ ........ ........ 
                  : ........ .......x ........ ........   ........ ........ ........ ........ 
                  : ........ ........ ........ ........   ........ ........ ........ ........ 
                  : ........ ........ ........ ........   ........ ........ ........ ........ 
                  : ........ ........ ........ ........   ...x.... ........ ........ ........ 
                  : ........ ........ ........ ........   ........ ........ ........ ........ 
                  : ........ ........ ........ ........   
                  : Passive (6), Include In Advanced Combat Log (72), Not In Spellbook (143), Do Not Log on Learn (355)
 Effects          :
 #1 (id=1014577)  : Apply Aura (6) | Dummy (4)
                    Base Value: 3 | Scaled Value: 3 | PvP Coefficient: 1.00000 | Misc Value: 14 | Target: Self (1)
 #2 (id=1014578)  : Apply Aura (6) | Dummy (4)
                    Base Value: 1 | Scaled Value: 1 | PvP Coefficient: 1.00000 | Target: Self (1)
 #3 (id=1014579)  : Apply Aura (6) | Apply Percent Modifier w/ Label (218): Spell Direct Amount (0)
                    Base Value: -70 | Scaled Value: -70 | PvP Coefficient: 1.00000 | Misc Value 2: 1778 (Label) | Target: Self (1)
-                   Affected Spells (Label): Whirlwind (385228), Whirlwind (385233), Whirlwind Off-Hand (385234)
+                   Affected Spells (Label): Whirlwind (385228), Whirlwind (385233), Whirlwind Off-Hand (385234), Cleave (458459)
 #4 (id=1014580)  : Apply Aura (6) | Dummy (4)
                    Base Value: -70 | Scaled Value: -70 | PvP Coefficient: 1.00000 | Target: Self (1)
 #5 (id=1033386)  : Dummy (3)
                    Base Value: 30 | Scaled Value: 30 | PvP Coefficient: 1.00000
-Description      : If Whirlwind $?s436707[or Thunder Clap ][]$?a137048[or Revenge ][]hits $s1 or more enemies, it hits them $s2 additional time for $s5% damage.
+Description      : If Whirlwind $?c1[or Cleave ][]$?s436707[or Thunder Clap ][]$?a137048[or Revenge ][]hits $s1 or more enemies, it hits them $s2 additional time for $s5% damage.
Armadk commented 1 month ago

but they finally got them all right and they all appear to repeat at 30% as intended ok yeah here it is If you open with Cleave vs 3+ targets, the Seismic damage benefits from Deep Wounds, even though the initial hit does not and the debuff hasn't had time to tick yet so it goes Cleave damage - apply mastery via Deep Wounds - Seismic damage - Deep Wounds tick damage which is technically correct, but makes it look like Seismic is doing >30% under those conditions

Armadk commented 1 month ago

Cleave has been implemented. No procs that happen on normal cleave were observed on the seismic cleave.

Armadk commented 1 month ago

TC was implemented as well. TB still needs to be done, but can get done with the rest of thane. Closing this out.