replace deprecated `contains` with `includes`

ebryn / ember-model

A lightweight model library for Ember.js

MIT License

524 stars 159 forks source link

Closed GavinJoyce closed 7 years ago

GavinJoyce commented 7 years ago

I'll address the getOwner deprecations once this has merged

TRMW commented 7 years ago

Would love to see this merged!

GavinJoyce commented 7 years ago

@ebryn might it be possible to either merge this and other valid PRs or perhaps give commit rights to someone else who can? Thanks

GavinJoyce commented 7 years ago

@eventualbuddha perhaps you might be able to review this? LMK if you can't and I'll try find someone else

eventualbuddha commented 7 years ago

Ping @GavinJoyce

GavinJoyce commented 7 years ago

@eventualbuddha I've added some context to the reason that the test change was needed above. Good to merge?

eventualbuddha commented 7 years ago

Thanks @GavinJoyce!