Feat surplus invariant

[GalloDaSballo]

• TODO - Let it cook

Summary by CodeRabbit

• New Features

  • Introduced GitHub Actions workflow for invariant testing.
  • Added Chainlink Adapter contract for fetching and converting Chainlink oracle price data.
  • Implemented new EbtcFeed contract for mainnet price feed connectivity.
  • New contracts and interfaces for enhanced TWAP (Time-Weighted Average Price) calculations and CDP (Collateralized Debt Position) management.
  • Expanded test suite with ActivePoolTwapAccTest for TWAP functionality testing and various other test enhancements for contract functionality verification.

• Enhancements

  • Updated contracts with new dependencies and logic for improved system debt handling, liquidation functions, redemption logic, and collateral surplus handling.
  • Enhanced price feed functionality with multiple feed types and error handling.
  • Improved governance contracts with refined loop conditions and additional checks for setting fee recipient addresses.

• Bug Fixes

  • Adjusted contract logic to handle overflow conditions and ensure accurate TWAP calculations.
  • Fixed issues in CDP management logic, including liquidation and collateral handling.

• Documentation

  • Updated .gitignore entries for better management of local deployment outputs and directories.

• Refactor

  • Consolidated and optimized contract logic for better efficiency and readability.
  • Refined interfaces and data structures for clearer contract interactions and functionality.

• Tests

  • Significantly expanded testing framework for contracts, including new scenarios for price feeds, CDP management, and TWAP functionality.
  • Introduced new test contracts for specific functionality verification and error scenario testing.

[getrecon-bot]

Job ID	b0650327-5f80-4fae-895b-ffef52f9ba05
Command	yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000
Instance ID	i-07743b559921a0498
Instance Type	c5.2xlarge
Status	Started
Elapsed

[getrecon-bot]

Job ID	b0650327-5f80-4fae-895b-ffef52f9ba05
Command	yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000
Instance ID	i-07743b559921a0498
Instance Type	c5.2xlarge
Status	Running
Elapsed	42 seconds

[getrecon-bot]

Job ID	b0650327-5f80-4fae-895b-ffef52f9ba05
Command	yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000
Instance ID	i-07743b559921a0498
Instance Type	c5.2xlarge
Status	Running
Elapsed	43 seconds

[coderabbitai[bot]]

Walkthrough

The recent updates bring a holistic transformation to the contract ecosystem, emphasizing TWAP integration, CDP management refinement, and enhanced price feed mechanisms using Chainlink adapters. Governance processes are streamlined, debt and collateral handling is refined, and system robustness is fortified through mathematical safeguards and improved testing frameworks. These changes aim to elevate system integrity, efficiency, and user experience.

Changes

Files	Change Summary
.github/workflows/invariant-test.yml	Introduced invariant-test GitHub Actions workflow.
packages/contracts/.gitignore	Updated to ignore new files and directories.
packages/contracts/contracts/...	Integrated TwapWeightedObserver, EbtcMath, and adjusted contract logic and dependencies.
packages/contracts/contracts/Dependencies/...	Added new functions, constants, and refined authority handling.
packages/contracts/contracts/Interfaces/...	Updated interfaces with new functions and events while removing outdated ones.
packages/contracts/contracts/TestContracts/...	Enhanced testing contracts with new logic, functions, and invariants for robust testing.
packages/contracts/foundry_test/...	Adjusted and removed tests reflecting changes in governance, TWAP calculations, and contract operations.

"In the code's woven warren, rabbits toil with care,
Twap and Chainlink blend, a magic rare.
Through contracts' maze, with math as guide,
They refine, test, and tweak, with pride.
🌟 To solidity and beyond, our changes soar,
A leap towards perfection, forever more."
🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

---

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.

[getrecon-bot]

Job ID	b0650327-5f80-4fae-895b-ffef52f9ba05
Command	yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000
Instance ID	i-07743b559921a0498
Instance Type	c5.2xlarge
Status	Error
Elapsed	1 day 2 hours 30 minutes 58 seconds