Closed balazsorban44 closed 5 years ago
Merging #16 into develop will increase coverage by
11.66%
. The diff coverage is62%
.
@@ Coverage Diff @@
## develop #16 +/- ##
============================================
+ Coverage 33.05% 44.72% +11.66%
============================================
Files 18 22 +4
Lines 118 161 +43
Branches 11 17 +6
============================================
+ Hits 39 72 +33
- Misses 68 76 +8
- Partials 11 13 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/App.js | 33.33% <ø> (ø) |
:arrow_up: |
src/lib/i18next.js | 100% <ø> (ø) |
:arrow_up: |
src/lib/router.js | 100% <ø> (ø) |
:arrow_up: |
src/components/Landing/index.js | 0% <0%> (ø) |
|
src/lib/firebase.js | 100% <100%> (ø) |
:arrow_up: |
src/db/Store.js | 100% <100%> (+87.5%) |
:arrow_up: |
src/components/Register.jsx | 50% <50%> (ø) |
|
src/components/Dashboard.jsx | 66.66% <66.66%> (ø) |
|
src/components/Profile.jsx | 66.66% <66.66%> (ø) |
|
src/db/actions/users.js | 81.81% <81.81%> (ø) |
|
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e950f44...e3cc9e4. Read the comment docs.
Updated Lighthouse report for the changes in this PR:
Category | New score | Required threshold |
---|---|---|
SEO | 80 | - |
Performance | 0 | - |
Progressive Web App | 100 | 1 |
Accessibility | 81 | - |
Best Practices | 93 | - |
Tested with Lighthouse version: 4.1.0
Updated Lighthouse report for the changes in this PR:
Category | New score | Required threshold |
---|---|---|
SEO | 80 | - |
Performance | 0 | - |
Progressive Web App | 100 | 1 |
Accessibility | 81 | - |
Best Practices | 93 | - |
Tested with Lighthouse version: 4.1.0
Before I opened this Pull Request, I have:
CHANGELOG.md
file 📝according to my best knowledge.