Closed toretefre closed 5 years ago
Merging #29 into feature/messages will increase coverage by
3.49%
. The diff coverage is40%
.
@@ Coverage Diff @@
## feature/messages #29 +/- ##
====================================================
+ Coverage 53.04% 56.54% +3.49%
====================================================
Files 39 30 -9
Lines 328 237 -91
Branches 53 30 -23
====================================================
- Hits 174 134 -40
+ Misses 132 89 -43
+ Partials 22 14 -8
Impacted Files | Coverage Δ | |
---|---|---|
src/lib/router.js | 100% <ø> (ø) |
:arrow_up: |
src/App.js | 57.14% <ø> (-30.36%) |
:arrow_down: |
src/lib/i18next.js | 100% <ø> (ø) |
:arrow_up: |
src/components/Dashboard.jsx | 66.66% <0%> (+16.66%) |
:arrow_up: |
src/lib/firebase.js | 100% <100%> (ø) |
:arrow_up: |
src/components/Messages.jsx | 33.33% <33.33%> (ø) |
:arrow_up: |
src/components/Departure.jsx | 41.66% <41.66%> (+41.66%) |
:arrow_up: |
src/components/shared/DestructButton.jsx | 100% <0%> (ø) |
:arrow_up: |
... and 16 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 792d4b8...6cd0a7e. Read the comment docs.
Updated Lighthouse report for the changes in this PR:
Category | New score | Required threshold |
---|---|---|
SEO | 80 | - |
Performance | 0 | - |
Progressive Web App | 100 | 1 |
Accessibility | 81 | - |
Best Practices | 93 | - |
Tested with Lighthouse version: 4.1.0
Moving milestone up to Sprint 2, as it was not finished on time.
Updated Lighthouse report for the changes in this PR:
Category | New score | Required threshold |
---|---|---|
SEO | 80 | - |
Performance | 0 | - |
Progressive Web App | 100 | 1 |
Accessibility | 81 | - |
Best Practices | 93 | - |
Tested with Lighthouse version: 4.1.0
Good suggestions. Will implement them as soon as possible.
Implementing first version of #13
Before I opened this Pull Request, I have:
CHANGELOG.md
file 📝according to my best knowledge.