Closed balazsorban44 closed 5 years ago
Merging #47 into develop will decrease coverage by
16%
. The diff coverage is18.98%
.
@@ Coverage Diff @@
## develop #47 +/- ##
============================================
- Coverage 60.07% 44.06% -16.01%
============================================
Files 32 44 +12
Lines 278 413 +135
Branches 39 69 +30
============================================
+ Hits 167 182 +15
- Misses 95 199 +104
- Partials 16 32 +16
Impacted Files | Coverage Δ | |
---|---|---|
src/components/Boats.jsx | 0% <ø> (ø) |
:arrow_up: |
src/lib/i18next.js | 100% <ø> (ø) |
:arrow_up: |
src/lib/router.js | 100% <ø> (ø) |
:arrow_up: |
src/db/actions/messages.js | 0% <0%> (ø) |
|
src/components/Departure.jsx | 0% <0%> (ø) |
|
src/components/shared/InputDropdown.js | 0% <0%> (ø) |
|
src/utils/firebase.js | 0% <0%> (ø) |
|
src/utils/validate.js | 0% <0%> (ø) |
|
src/components/Landing/index.js | 42.85% <0%> (ø) |
:arrow_up: |
src/db/actions/users.js | 66.66% <0%> (-6.07%) |
:arrow_down: |
... and 29 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4eaf122...b37265f. Read the comment docs.
Updated Lighthouse report for the changes in this PR:
Category | New score | Required threshold |
---|---|---|
SEO | 80 | 1 |
Performance | 0 | - |
Progressive Web App | 100 | 90 |
Accessibility | 81 | 80 |
Best Practices | 100 | 80 |
Tested with Lighthouse version: 4.1.0
Updated Lighthouse report for the changes in this PR:
Category | New score | Required threshold |
---|---|---|
SEO | 80 | 1 |
Performance | 0 | - |
Progressive Web App | 100 | 90 |
Accessibility | 81 | 80 |
Best Practices | 100 | 80 |
Tested with Lighthouse version: 4.1.0
Before I opened this Pull Request, I have:
CHANGELOG.md
file 📝according to my best knowledge.
32 , #38
Closes #13