ecatch-kyst / web

IT Bachelor project @ NTNU ⚑🎣
https://ecatch-kyst-beta.firebaseapp.com
GNU General Public License v3.0
5 stars 0 forks source link

Feature/prevent redirect #58

Closed PetterRein closed 5 years ago

PetterRein commented 5 years ago

Before I opened this Pull Request, I have:

according to my best knowledge.

Closes #53 , closes #55

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 80 1
Performance 0 -
Progressive Web App 100 90
Accessibility 81 80
Best Practices 100 80

Tested with Lighthouse version: 4.1.0

codecov[bot] commented 5 years ago

Codecov Report

Merging #58 into develop will increase coverage by 0.29%. The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #58      +/-   ##
===========================================
+ Coverage    38.88%   39.18%   +0.29%     
===========================================
  Files           44       44              
  Lines          414      416       +2     
  Branches        69       70       +1     
===========================================
+ Hits           161      163       +2     
  Misses         221      221              
  Partials        32       32
Impacted Files Coverage Ξ”
src/components/shared/Page.jsx 100% <100%> (ΓΈ) :arrow_up:
src/db/actions/users.js 68% <50%> (+1.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 018e4ff...b5bec38. Read the comment docs.

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 80 1
Performance 0 -
Progressive Web App 100 90
Accessibility 81 80
Best Practices 100 80

Tested with Lighthouse version: 4.1.0