toretefre commented 5 years ago

Hotfix that adresses #61.

Reviewer should verify that nothing changes for Linux and Windows users.

Before I opened this Pull Request, I have:

[x] referenced all the issues in commits related to this PR

according to my best knowledge.

Changelog, tests and comments are not applicable.

toretefre commented 5 years ago

May want to change the dropdown variable into dropdownvalues in Dropdown.jsx and DropdownMap.jsx , please mark with changes requested if wanted, thanks!

codecov[bot] commented 5 years ago

Codecov Report

Merging #64 into develop will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #64   +/-   ##
========================================
  Coverage    39.18%   39.18%           
========================================
  Files           44       44           
  Lines          416      416           
  Branches        70       70           
========================================
  Hits           163      163           
  Misses         221      221           
  Partials        32       32

Impacted Files	Coverage Δ
src/components/Forms/components/Dropdown.jsx	`15% <ø> (ø)`	:arrow_up:
src/components/Forms/components/DropdownMap.jsx	`14.28% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d620a02...32ad724. Read the comment docs.

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category	New score	Required threshold
SEO	80	1
Performance	52	-
Progressive Web App	100	90
Accessibility	81	80
Best Practices	100	80

Tested with Lighthouse version: 4.1.0

ecatch-kyst / web

Hotfix for dropdown nameconflict #64

Codecov Report