ecatch-kyst / web

IT Bachelor project @ NTNU ⚡🎣
https://ecatch-kyst-beta.firebaseapp.com
GNU General Public License v3.0
5 stars 0 forks source link

Feature/add fishing spot #70

Closed Mortefal closed 5 years ago

Mortefal commented 5 years ago

Before I opened this Pull Request, I have:

according to my best knowledge.

52

closes #46

codecov[bot] commented 5 years ago

Codecov Report

Merging #70 into develop will decrease coverage by 0.88%. The diff coverage is 16.12%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #70      +/-   ##
===========================================
- Coverage    42.36%   41.47%   -0.89%     
===========================================
  Files           50       52       +2     
  Lines          550      569      +19     
  Branches       102      104       +2     
===========================================
+ Hits           233      236       +3     
- Misses         281      297      +16     
  Partials        36       36
Impacted Files Coverage Δ
src/db/actions/messages.js 0% <ø> (ø) :arrow_up:
src/components/Forms/components/DropdownMap.jsx 10.81% <ø> (ø) :arrow_up:
src/components/shared/Dialog.jsx 80% <ø> (ø) :arrow_up:
src/components/Forms/FormInput.jsx 92.3% <ø> (ø) :arrow_up:
src/components/Forms/components/TextInput.jsx 0% <ø> (ø) :arrow_up:
src/db/actions/dialog.js 87.5% <ø> (ø) :arrow_up:
src/db/actions/customLists.js 0% <0%> (ø)
src/db/Store.js 38.46% <0%> (-3.21%) :arrow_down:
src/components/Forms/components/Dropdown.jsx 11.11% <12.5%> (-2.53%) :arrow_down:
src/components/Forms/components/GeoPointInput.jsx 12.5% <12.5%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c120af...d231dca. Read the comment docs.

lighthousebot commented 5 years ago

Updated Lighthouse report for the changes in this PR:

Category New score Required threshold
SEO 82 1
Performance 0 -
Progressive Web App 100 90
Accessibility 81 80
Best Practices 100 80

Tested with Lighthouse version: 4.2.0