ecatch-kyst / web

IT Bachelor project @ NTNU ⚑🎣
https://ecatch-kyst-beta.firebaseapp.com
GNU General Public License v3.0
5 stars 0 forks source link

Feature/favorite in dropdown #99

Closed PetterRein closed 5 years ago

PetterRein commented 5 years ago

Before I opened this Pull Request, I have:

52

according to my best knowledge.

codecov[bot] commented 5 years ago

Codecov Report

Merging #99 into develop will decrease coverage by 2.67%. The diff coverage is 19.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #99      +/-   ##
===========================================
- Coverage    44.79%   42.11%   -2.68%     
===========================================
  Files           57       59       +2     
  Lines          672      729      +57     
  Branches       132      135       +3     
===========================================
+ Hits           301      307       +6     
- Misses         323      371      +48     
- Partials        48       51       +3
Impacted Files Coverage Ξ”
src/lib/router.js 100% <ΓΈ> (ΓΈ) :arrow_up:
src/App.js 87.5% <ΓΈ> (ΓΈ) :arrow_up:
src/lib/i18next.js 18.75% <ΓΈ> (ΓΈ) :arrow_up:
src/db/actions/customLists.js 0% <0%> (ΓΈ) :arrow_up:
src/db/Store.js 26.31% <0%> (-12.15%) :arrow_down:
src/components/Forms/components/GeoPointInput.jsx 57.89% <100%> (ΓΈ) :arrow_up:
src/components/Forms/components/TextInput.jsx 85.71% <100%> (ΓΈ) :arrow_up:
src/components/Preset/index.js 25% <25%> (ΓΈ)
src/components/Forms/components/Dropdown.jsx 34.69% <25.71%> (-30.31%) :arrow_down:
src/components/Preset/components/AddFavorite.js 6.66% <6.66%> (ΓΈ)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update ef0814c...977d3b7. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #99 into develop will increase coverage by 0.36%. The diff coverage is 59.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #99      +/-   ##
===========================================
+ Coverage    44.79%   45.15%   +0.36%     
===========================================
  Files           57       59       +2     
  Lines          672      702      +30     
  Branches       132      135       +3     
===========================================
+ Hits           301      317      +16     
- Misses         323      335      +12     
- Partials        48       50       +2
Impacted Files Coverage Ξ”
src/App.js 87.5% <ΓΈ> (ΓΈ) :arrow_up:
src/lib/i18next.js 18.75% <ΓΈ> (ΓΈ) :arrow_up:
src/lib/router.js 100% <ΓΈ> (ΓΈ) :arrow_up:
src/db/actions/customLists.js 0% <0%> (ΓΈ) :arrow_up:
src/db/Store.js 26.31% <0%> (-12.15%) :arrow_down:
src/components/Forms/components/GeoPointInput.jsx 57.89% <100%> (ΓΈ) :arrow_up:
src/components/Preset/index.js 100% <100%> (ΓΈ)
src/components/Forms/components/TextInput.jsx 85.71% <100%> (ΓΈ) :arrow_up:
src/components/Forms/components/Dropdown.jsx 64% <71.42%> (-1%) :arrow_down:
src/components/Preset/components/AddFavorite.jsx 76.92% <76.92%> (ΓΈ)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update ef0814c...4d73be2. Read the comment docs.

PetterRein commented 5 years ago

52 solves some of the points