search

echasnovski / mini.nvim

Library of 40+ independent Lua modules improving overall Neovim (version 0.8 and higher) experience with minimal effort
MIT License
4.74k stars 178 forks source link

Missing transparency on some elements when applying add_transparency #818

Closed wroyca closed 1 week ago

wroyca commented 4 months ago

Contributing guidelines

Module(s)

Colors

Description

Hello o/

Using add_transparency({float = true}) with MiniColors will miss some elements, (e.g. MiniFilesTitles, MiniClueNextKeys, ...)

These are not "float" if we are pedantic with the definition, but they're part (as in, elements) of Mini floats so I believe they should follow suit

Neovim version

NVIM v0.10.0-dev+2931-g7fa24948a

Steps to reproduce

  1. nvim -nu minimal.lua
  2. lua MiniColors.interactive()
  3. add_transparency({float = true})
  4. lua MiniFiles.open() or lua MiniPick.builtin.grep_live() or others.

Expected behavior

Title, keys, and others that are on a transparent float should also have a transparent background to not look out of place.

Actual behavior

Screenshot from 2024-04-17 11-21-09 Screenshot from 2024-04-17 11-21-17 image

echasnovski commented 4 months ago

Thanks for the suggestion!

MiniColors.add_transparency() is mostly designed to work with built-in groups. Making exceptions for 'mini.nvim' is possible, but might be not very sustainable in the long run. I'll think about it.

echasnovski commented 1 week ago

I think sticking to built-in groups in this kind of functionality is better from maintenance perspective.

Closing as not planned.