significant code duplication in client10 and client11 modules

eclecticiq / cabby

TAXII client implementation from EclecticIQ

Other

98 stars 21 forks source link

significant code duplication in client10 and client11 modules #15

Closed wbolster closed 9 years ago

wbolster commented 9 years ago

just a general remark, not sure how to cleanly abstract those difference away, though...

traut commented 9 years ago

could you elaborate please? client10 and client11 differ in 2 ways: they use different classes (for TAXII 1.0 and TAXII 1.1) and they have different logic (because of different spec). I moved obvious generic logic blocks to abstract.py and I feel that abstracting even more may lead to bloated code