search

eclipse-aaspe / package-explorer

AASX Package Explorer
Other
64 stars 19 forks source link

[BUG] Submodel plugins triggered when SmenaticId modelType is set to "Submodel", but not to "GlobalReference" #231

Open StenGruener opened 4 months ago

StenGruener commented 4 months ago

Describe the bug Submodel Plugin is triggered only of Semantic ID has "Submodel" set as the key, e.g., digital nameplate v2.

https://github.com/eclipse-aaspe/package-explorer/blob/863fbd5ba607a1291c0088be6154b3041b02db02/src/AasxPredefinedConcepts/Resources/DigitalNameplateV20.json#L26

"modelType": "Submodel"

However I read the AAS-spec in such a way that for ExternalReferences model type should be "GlobalReference"

https://admin-shell-io.github.io/aas-specs-antora/IDTA-01001/v3.1/spec-metamodel/referencing.html#_constraints

Constraint AASd-122: For external references, i.e. References with Reference/type = ExternalReference, the value of Key/type of the first key of Reference/keys shall be one of GenericGloballyIdentifiables.

Maybe those lines should be set to GlobalReference or just ignoring modelType?

juileetikekar commented 3 months ago

Hi @StenGruener,

Thank you for the issue.

We are in the internal discussion regarding the probable combination of ReferenceType and KeyType for a semanticId of an SMT.