eclipse-apoapsis / .eclipsefdn

Repository to host configurations related to the Eclipse Foundation.
https://eclipse-apoapsis.github.io/.eclipsefdn/
1 stars 1 forks source link

chore: Align website config for guidance with ort-server #18

Closed mnonnenmacher closed 1 month ago

eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot.

Thank you for raising a pull request to update the configuration of your GitHub organization. You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

Otterdog commands and options You can trigger otterdog actions by commenting on this PR: - `/otterdog team-info` checks the team / org membership for the PR author - `/otterdog validate` validates the configuration change - `/otterdog validate info` validates the configuration change, printing also validation infos - `/otterdog check-sync` checks if the base ref is in sync with live settings - `/otterdog merge` merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author) - `/otterdog done` notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team) - `/otterdog apply` re-apply a previously failed attempt (only accessible for members of the admin team)
eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot.

The author (mnonnenmacher) of this PR is associated with this organization in the role of MEMBER.

Additionally, mnonnenmacher is a member of the following teams:

eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot. Please find below the validation of the requested configuration changes:

Diff for bb3352e87438d273a4b630d6c399c82361ed953b ```diff Organization technology.apoapsis[id=eclipse-apoapsis] ╷ │ Error: failed to load configuration │ │ failed to evaluate jsonnet file: /app/work/tmp/worker-11/tmp8qvy9vwj/eclipse-apoapsis/eclipse-apoapsis.jsonnet:44:7-26 Duplicate field: gh_pages_build_type │ │ gh_pages_build_type: "workflow", │ ╵ ```
eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot. The current configuration is in-sync with the live settings. :rocket:

eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot. Please find below the validation of the requested configuration changes:

Diff for 0d7bbee3f7a0b7f05a974c395dc34a9afe4a7259 ```diff Organization technology.apoapsis[id=eclipse-apoapsis] ! repository[name="guidance"] { ! homepage = null -> "https://eclipse-apoapsis.github.io/guidance/" ! } ! environment[name="github-pages", repository="guidance"] { ! branch_policies = [ - gh_pages ! ] ! } Plan: 0 to add, 2 to change, 0 to delete. ```
eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot. This Pull Request is eligible for auto-merging as it passed the following checks:

In order to automatically merge and apply the changes, add a comment /otterdog merge. :rocket:

eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot. The current configuration is in-sync with the live settings. :rocket:

mnonnenmacher commented 1 month ago

/otterdog merge

eclipse-otterdog[bot] commented 1 month ago

This is your friendly self-service bot.

The following changes have been successfully applied:


Organization technology.apoapsis[id=eclipse-apoapsis]

!   repository[name="guidance"] {
!     homepage = null -> "https://eclipse-apoapsis.github.io/guidance/"
!   }

!   environment[name="github-pages", repository="guidance"] {
!     branch_policies = [
-      gh_pages
!     ]
!   }

  Applying changes:

  Done.

  Executed plan: 0 added, 2 changed, 0 deleted.
netomi commented 1 month ago

wow nice, the new diff view for lists works, hope it is understandable.

Instead of showing the whole list, only the set of changes are shown based on the standard diff algorithm included in python (which is not optimal afaict, but still very useful)

mnonnenmacher commented 1 month ago

wow nice, the new diff view for lists works, hope it is understandable.

Instead of showing the whole list, only the set of changes are shown based on the standard diff algorithm included in python (which is not optimal afaict, but still very useful)

Yes, to me it's understandable, and definitely better than just showing the new value. But I noticed that in my other PR where I removed a required check it was not using the diff view: https://github.com/eclipse-apoapsis/.eclipsefdn/pull/17#issuecomment-2411218615

netomi commented 1 month ago

ty for pointing out this case, it looks like the list got converted to a string in this case, looks like an oversight, will fix it.

netomi commented 1 month ago

should be fixed with this commit: https://github.com/eclipse-csi/otterdog/commit/7539e082870c767337ea94cd700481bc42e4d535

mnonnenmacher commented 1 month ago

should be fixed with this commit: eclipse-csi/otterdog@7539e08

Nice, I'll check it next time we change our required checks.