eclipse-aspectj / aspectj

Other
303 stars 86 forks source link

Eclipse Distribution License #224

Open sirinath opened 1 year ago

sirinath commented 1 year ago

Dual license with Eclipse Distribution License (https://www.eclipse.org/org/documents/edl-v10.php).

Since EPLv1 to EPLv2 change has been done making this addition will be easy.

kriegaex commented 1 year ago

@sirinath, add to where exactly?

@aclement, you are the project lead, you should be in the loop and ideally comment on this issue.

sirinath commented 1 year ago

add to where exactly?

@kriegaex The EDL license can be added to the root directory of the project. See: https://github.com/eclipse/eclipse-collections

kriegaex commented 1 year ago

Does it have to be added to binary artifacts (JARs) we publish on Maven Central, too?

sirinath commented 1 year ago

Yes.

aclement commented 1 year ago

This has come up before. I seem to recall it not being trivial to add it and I think it was you who asked for it before Sirinath. Let me try and find where it was discussed.

aclement commented 1 year ago

Maybe you were just actually taking the action I recommended for you in this thread : https://www.eclipse.org//lists/aspectj-dev/msg03304.html :)

I still have no idea how much work it is. If it requires checking with all previous committers of the code that it can be relicensed - bit of a no go. If inclusion of EPL makes EDL a no-op easy thing to do, I am probably ok with it subject to us reviewing what the requirements are for distribution. We would need to ask someone at the eclipse org to confirm, I wouldn't blindly make the change.

I asked chatgpt :) and it said it would probably be ok but ended with "you should ask a legal professional" so back to what I said. I'd raise a question with eclipse to confirm.

sirinath commented 1 year ago

When the license was changed to EPL 2.0 all the license assignments should have already done and the needed work is complete, hence adding EDL now is a lot simpler than when it was EPL 1.0.

aclement commented 1 year ago

Just to clarify, by:

I'd raise a question with eclipse to confirm. I was implying we, the project, would raise that request with legal for confirmation.

kriegaex commented 10 months ago

@aclement, has what is the status quo here? Did you talk to legal?